Skip to content

Release 1.17.0 (build 32): adopt core 2.60.1, folder pickers open without the keyboard - #39

Open
adibhanna wants to merge 3 commits into
mainfrom
release/1.17.0
Open

adibhanna wants to merge 3 commits into
mainfrom
release/1.17.0

Conversation

@adibhanna

Copy link
Copy Markdown
Contributor

Summary

  • Adopt core-2.60.1-core.h94c9a734ea3c33cf (draft until both shells ship), built from ZenNotes/zennotes ac879d14e83464c974fb9fb4d7629ea158490300 on v2.61.0: core 2.60.0 plus fix 0c3071a6. Android 1.1.30 (Release 1.1.30 (versionCode 33): adopt core 2.60.1, folder pickers open without the keyboard zennotesandroid#92) vendors the identical archives.
  • What it fixes: since core 2.53.0 the phone's folder pickers (Move to… for a note or a folder) opened with the soft keyboard up over the list they ask you to tap, because the shared dialog shell focused the input PromptModal deliberately leaves alone on touch. Core 2.60.1 keeps them tap-first: focus moves into the dialog, no keyboard, one tap on the field raises it. Rename and New folder still open with the keyboard.
  • MoveDirectoryUITests now treats a control under the software keyboard as not tappable yet: with tap-first restored the test types right after tapping the field, before the shell lifts the sheet, and XCUITest failed on the Move button instead of waiting.
  • Version 1.17.0 (build 32): the six marketing/build pairs.

Verification

  • core:adopt: SHA-256, SHA-512, packed versions and clean-source provenance verified. Lockfile is main's with only the root pins and the three @zennotes entries swapped; npm ci accepts it.
  • Boundaries, typecheck, 125/125 tests, production audit (0 vulnerabilities), build and Capacitor sync passed.
  • iPhone 17 Pro Max (iOS 27) simulator, scheme AppCloudUITests: DeepLinkUITests (2), FavoriteUITests and SearchCreateUITests (2) passed; MoveDirectoryUITests passed 3 iterations in a row after the keyboard guard (it had failed once on the Move button before it).
  • By hand on the 1.17.0 (32) Debug build: Browse, long-press a note, Move to… opens with the folder list visible and no keyboard.

Release notes

1.16.0 (31) is still in App Review. This is prepared to follow it; no archive or upload yet.

…oard

Core 2.52.0 to 2.60.0 opened every touch folder picker (Move to… for a note
or a folder) with the soft keyboard up over the list it asks you to tap:
the shared dialog shell focused the prompt's input that PromptModal had
deliberately left alone. Core 2.60.1 (core-2.60.1-core.h94c9a734ea3c33cf,
built from ZenNotes/zennotes ac879d14 on v2.61.0, fix 0c3071a6) keeps those
pickers tap-first: focus moves into the dialog, no keyboard, and one tap on
the field raises it.

tooling/adopt-core.mjs verified all three archives against SHA-256,
SHA-512, packed versions and clean-source provenance. The lockfile is
main's with only the root pins and the three @ZenNotes entries swapped
(the local npm drops libc fields Dependabot's npm writes); npm ci accepts
it unchanged. Boundaries, TypeScript, 125 tests, zero production
vulnerabilities and Capacitor sync passed.
… keyboard

With core 2.60.1 the Move prompt is tap-first again, so the test taps the
field and types at once, and the keyboard arrives a moment before the
shell lifts the sheet above it. Looking for the Move button in that moment
found it under the keyboard, where XCUITest cannot compute a hit point and
fails the test ("Activation point invalid") instead of answering false;
the run's screenshot shows the typed name with the sheet still behind the
keyboard. hittableMatch now treats a control under the software keyboard
as not tappable yet and keeps polling until the sheet settles. Three
iterations in a row passed on the iPhone 17 Pro Max (iOS 27) simulator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant