Repository navigation
Release 1.1.38 (versionCode 41): adopt core 2.68.0 - #110
Merged
Merged
Conversation
Core core-2.68.0-core.h6e3db1e19bc2b662, built by CI from
ZenNotes/zennotes 881baa6a (the v2.68.0 release commit, boundary run
38327475651), adopted with core:adopt pinned to that commit with
--source (SHA-256, SHA-512, packed versions and clean-source provenance
checked). For phones it carries the heading indent guard (#925: Tab,
Vim's indent keys and the toolbar's Indent button leave a heading at the
margin and say why), Preview tables that keep the column widths set in
the editor and scroll sideways (#920), and app text without long
dashes, which also renames the demo tour notes ("00 Start Here").
The desktop-only additions stay off on Android without shell changes.
The new bridge members (sendUsageCount, listAgentEdits, readAgentEdit,
writeAgentEdit, supportsAgentEditReview) are optional and this bridge
leaves them out, so the agent edit review commands and note banner
never appear. What's New in ZenNotes is gated on a desktop host in its
palette command, its launch hook and :whatsnew, and the anonymous count
setting renders on the desktop runtime only. Every title-matched hide in
MobileShell.tsx and mobile.css still finds its element in this core.
The lockfile moves the three @ZenNotes pins and adds @codemirror/merge
6.12.2 (the agent edit review's diff view), whose dependencies were
already installed. Typecheck and 271 tests pass.
…rename
Core 2.68.0 renamed the demo tour's notes ("00 Start Here.md"; the older
names had a long dash between number and title). Desktop's
generateDemoTour and removeDemoTour take the notes still under the older
names with them, but this shell writes and removes the tour itself, over
the current names only. A phone that seeded the tour before this release
would have got a second copy of all 17 notes from Regenerate, whose
dialog promises to overwrite them, and Remove would have left the older
set behind with its Remove command still showing.
Both now do what desktop does (olderDemoTourNotePaths in
apps/desktop/src/main/vault.ts): Regenerate deletes the older files
before writing, and Remove deletes and reports them. A file counts only
when shared-domain's currentDemoTourPath, an exact match on the older
separator inside inbox/demo, maps it onto one of the tour's own notes,
so the shell holds no copy of the pattern and any other note in that
folder stays. The test covers a note named with a middle dot, one with
a hyphen, a long-dash name the tour never shipped and the older name
outside the folder, and fails against the previous code. Typecheck and
275 tests pass.
…e list 2.68.0 adds two desktop features to the command palette: What's New in ZenNotes, and one Review Agent Changes row per note an assistant edited through MCP. Neither reaches Android today. What's New is gated on a desktop host in its command, its launch hook and :whatsnew, and the review rows come from listAgentEdits, which this bridge leaves out. Both titles join DESKTOP_ONLY_COMMAND_TITLES anyway, as the shell's own guarantee: the bridge reports runtime 'web', so it inherits whatever a later core gives the web client. The What's New title is written with the ’ escape so its curly apostrophe stays exact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.1.38 on core 2.68.0.
Every title-matched hide (palette titles, settings sections and sub-tabs, the floating-window menu item, the title, aria-label and placeholder selectors in mobile.css) was re-checked against this core and still matches.
Local: typecheck clean, 275 tests pass, the production audit gate passes; testDebugUnitTest (21 Java tests), lintDebug (0 errors) and assembleDebug pass. No local emulator run; the CI emulator job covers launch.