UX: Add copy icon to IP address and cleanup XML#32
UX: Add copy icon to IP address and cleanup XML#32manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
- Added `ic_content_copy.xml` vector drawable. - Updated `fragment_camera.xml` to include the copy icon on the IP address TextView (`textView6`). - Applied `drawableTint` to match the link color and added padding for better visual separation. - Removed duplicate `android:labelFor` and `android:importantForAccessibility` attributes in `fragment_camera.xml` to fix build warnings/errors. This improves the discoverability of the "click to copy" feature for the IP address. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR enhances the UX by adding a visual "copy" icon to the IP address text in the camera fragment. Previously, the IP address was clickable to copy, but there was no visual indication of this functionality other than the text color. The addition of the standard content copy icon makes this feature much more discoverable.
Additionally, this PR cleans up
fragment_camera.xmlby removing duplicate XML attributes that were causing build warnings or errors.Changes:
app/src/main/res/drawable/ic_content_copy.xmlapp/src/main/res/layout/fragment_camera.xmlto adddrawableEnd,drawableTint, anddrawablePaddingtotextView6.fragment_camera.xml.PR created automatically by Jules for task 4373954716725224248 started by @manupawickramasinghe