feat(readers): support PN532Killer UART readers - #1158
Draft
treyturner wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the Zaparoo Core integration for PN532Killer UART readers.
Protocol and transport compatibility are implemented in the companion
go-pn532change:This PR is intentionally a draft until that change is merged and released. The branch currently contains the Linux permission and installer integration. After the library release is available, a final commit will update the
go-pn532dependency without using a committedreplacedirective.Changes
1a8655d3PN532Killer-UART0660and theuaccesstag.go-pn532to the first released version containing PN532Killer support before marking this PR ready.No new reader ID or configuration syntax is introduced. PN532Killer uses the existing native UART reader path, such as:
The legacy libnfc reader remains unchanged.
Validation
go test ./pkg/platforms/linux/installergo-pn532branch using an uncommittedgo.work.