fix(z-app-header): add searchLabel prop for visible search input label#659
Open
ada-workbackai wants to merge 2 commits intomasterfrom
Open
fix(z-app-header): add searchLabel prop for visible search input label#659ada-workbackai wants to merge 2 commits intomasterfrom
ada-workbackai wants to merge 2 commits intomasterfrom
Conversation
Users with cognitive disabilities or low vision need a persistent visible label on the search field that remains after they start typing.
Stencil build updated TypeScript declarations and component docs to include the new searchLabel prop on z-app-header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 3.3.2 (Labels or Instructions) by adding a
searchLabelprop toz-app-headerthat passes through toz-searchbar's existinglabelprop.Issue: The search input field in the app header relies solely on placeholder text for identification. Placeholder text disappears when users type, leaving no visible indication of the field's purpose or search capabilities (title, author, ISBN).
Solution:
z-searchbaralready supports alabelprop that renders a visible<label>element viaz-input. However,z-app-headerdid not expose this prop. This PR adds asearchLabelprop toz-app-headerthat is forwarded toz-searchbaraslabel.Consumer usage:
Test Plan
yarn build)components.d.tsandreadme.mdupdated correctlyz-app-headercurrently has nosearch-labelattribute setz-searchbarlabelprop renders a visible<label>elementEvidence
View before/after screenshots and full audit details:
https://app.workback.ai/issues/4br6zzrichzh6dytmdsfw84okc/
WCAG Reference:
3.3.2 Labels or Instructions