fix(z-input): add aria-describedby for password fields#629
Open
ada-workbackai wants to merge 1 commit intomasterfrom
Open
fix(z-input): add aria-describedby for password fields#629ada-workbackai wants to merge 1 commit intomasterfrom
ada-workbackai wants to merge 1 commit intomasterfrom
Conversation
Adds programmatic association between password inputs and their requirement messages to meet WCAG 3.3.2 (Labels or Instructions) Level A compliance. Changes: - Added aria-describedby attribute to input elements when message prop is provided - Added id attribute to z-input-message component for reference - Added password example story demonstrating proper usage with requirements - Updated label class name for consistency User impact: Screen reader users now hear password requirements when focusing on password fields, preventing form abandonment due to unclear validation rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 3.3.2 (Labels or Instructions) Level A by adding programmatic association between password input fields and their requirement instructions via
aria-describedby.Issue: Password fields in registration forms lack instructions about password requirements (minimum length, character types, etc.). Screen reader users cannot access these requirements if they are not programmatically associated with the input field, leading to form abandonment and accessibility violations.
Solution: Modified the
z-inputcomponent to automatically addaria-describedbyattribute when amessageprop is provided, linking the input to the helper text element.Changes
aria-describedbyattribute to input elements whenmessageprop is setidattribute (${htmlid}_message) toz-input-messagecomponentz-label→input-label)Test Plan
Usage Example
This will render an input with
aria-describedby="input-id_message"referencing the message element, ensuring screen readers announce the requirements when the field receives focus.Evidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/5036/
WCAG Reference:
3.3.2 Labels or Instructions (Level A)