fix(accessibility): add aria-required to required form fields#620
Open
ada-workbackai wants to merge 1 commit intomasterfrom
Open
fix(accessibility): add aria-required to required form fields#620ada-workbackai wants to merge 1 commit intomasterfrom
ada-workbackai wants to merge 1 commit intomasterfrom
Conversation
Adds aria-required="true" attribute to required form inputs and selects to ensure screen readers can programmatically determine which fields are mandatory. Fixes WCAG 3.3.2 (Labels or Instructions) violation where visual asterisks were not accessible to assistive technologies. Changes: - z-input: Add aria-required when required prop is true - z-select: Add required prop and pass to internal z-input Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 3.3.2 (Labels or Instructions) by adding
aria-required="true"to required form fields in the z-input and z-select components.Issue: Required form fields are marked with visual asterisks (*) but lack the
aria-requiredattribute. Screen readers cannot programmatically determine which fields are mandatory, leading to form submission errors and poor user experience for users with assistive technologies.Solution:
aria-required="true"to z-input whenrequiredprop is truerequiredprop to z-select component and passed it to the internal z-inputTest Plan
Evidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/2978/
WCAG Reference:
3.3.2 Labels or Instructions (Level A)