fix(z-input): increase password toggle button size to meet WCAG 2.5.8#617
Open
ada-workbackai wants to merge 1 commit intomasterfrom
Open
fix(z-input): increase password toggle button size to meet WCAG 2.5.8#617ada-workbackai wants to merge 1 commit intomasterfrom
ada-workbackai wants to merge 1 commit intomasterfrom
Conversation
The password visibility toggle button was 18×18 CSS pixels, falling 6px short of the WCAG 2.5.8 minimum target size requirement of 24×24px. This change increases the button size to 24×24px by setting CSS custom properties --z-icon-width and --z-icon-height on the .toggle-password-icon button element. Users with motor disabilities can now reliably toggle password visibility in login forms without difficulty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 2.5.8 (Target Size - Level AA) by increasing the password visibility toggle button from 18×18px to 24×24px.
Issue: The password visibility toggle button (eye icon) was only 18×18 CSS pixels, falling 6px short in both width and height of the WCAG 2.5.8 minimum target size requirement of 24×24px. This made it difficult for users with motor disabilities to reliably toggle password visibility in login forms.
Solution: Increased the button size to 24×24px by adding specific CSS custom properties (
--z-icon-widthand--z-icon-height) to the.toggle-password-iconselector instyles-text.css.Test Plan
Evidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/2849/
WCAG Reference:
2.5.8 Target Size (Minimum)