fix(z-button): render semantic anchors for link role#616
Open
ada-workbackai wants to merge 1 commit intomasterfrom
Open
fix(z-button): render semantic anchors for link role#616ada-workbackai wants to merge 1 commit intomasterfrom
ada-workbackai wants to merge 1 commit intomasterfrom
Conversation
Fixes WCAG 4.1.2 violation where buttons with role="link" were used instead of semantic anchor elements. When htmlrole or role is set to "link", the component now renders as an <a> element with proper href attribute, ensuring native keyboard support and correct assistive technology behavior. Changes: - Modified render() to detect link role and render as anchor - Anchors without explicit href default to "#" - Maintains backward compatibility with existing href usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 4.1.2 (Name, Role, Value) by ensuring z-button components with link semantics render as proper anchor elements instead of buttons with
role="link".Issue: When
htmlrole="link"or deprecatedrole="link"was set without anhrefattribute, the component rendered as a<button>element withrole="link". This violates WCAG 4.1.2 because non-semantic elements with ARIA roles must properly implement all required behaviors, keyboard interactions, and properties that native semantic elements provide automatically.Solution: Modified the z-button component to detect when link role is requested and render as a semantic
<a>element. When nohrefis provided, it defaults to"#"to maintain semantic correctness.Changes
render()method to check forhtmlrole="link"orrole="link"<a>element"#"as defaultroleattribute from button elements to prevent invalid ARIA usageTest Plan
htmlrole="link"is setEvidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/2842/
WCAG Reference:
4.1.2 Name, Role, Value (Level A)