Repository navigation
[TEST] system 도메인 테스트 코드 작성 #76 - #77
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughSystem 도메인에 서버 조회·액션, 결제 목 데이터, 공지 작성 컴포넌트의 테스트를 추가했다. 성공·실패, 검증, 페이지네이션, 필터, 파생 데이터 동작을 검증한다. ChangesSystem 도메인 테스트
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR 타입
🗂 작업 영역
🙋 관련 역할
📝 작업 내용
features/system에 테스트 40개(5 suites) 추가 — onboarding 스타일(순수 로직 + 핵심 컴포넌트 RTL)server.test.ts: 키워드 부분일치·대소문자 무시, 규모+상태 복합 필터, 범위 밖 페이지 당김, 격리막 목 통과actions.test.ts: 승인·반려 목록 제거+redirect, 정지/해제 상태변경+revalidatePath, 공지 서버측 빈값 가드mock/billing.test.ts: 구독 파생(항상 5건·미납 우선·요약 미납수=목록 소스 일치·Team 금액=인원×단가)notice-compose-card.test.tsx: 채우기 전 발행 잠금, 성공 안내, 실패 시 성공한 척 안 함(정직성)✅ 작업 체크리스트
기본
feature/meeting-capture#12꼴, basedevelop)type: 제목 #{이슈번호})Closes #에 이슈 번호 기입console· 주석 처리된 코드 제거.env)Z 필수
품질
getByRole·getByLabelText로 접근성 트리에 의존format.test.ts·onboarding 테스트 패턴 재사용loading/error/empty3상태 — 해당 없음(로직·상호작용 테스트)🔗 연관 이슈
Closes #76
📸 스크린샷 (선택)
💬 리뷰 포인트
afterEach복원 → 전체 219 tests 동시 실행에서 누수 없음server-only/next/cache/next/navigation목 대체 방식이 적절한지listMockCompanies()에서 계산 → 목 변경에 안 깨지는지📝 추가 메모
npx jest src/features/system→ 5 passed / 40 testsnpx jest(전체) → 19 suites / 219 tests 통과Summary by CodeRabbit