Repository navigation
Prepare 26.11.3 desktop and DNS fixes - #269
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Core launches select process DNS behavior by tunnel backend, alongside the desktop and DNS updates for 26.11.3.
Linux Core arguments keep their existing form. New advanced templates proxy non-address DNS queries, with loopback outbound validation. The branch also refreshes desktop dependencies and concise commit guidance.
Evidence
After: Tests assert the complete UWP and Wintun commands with explicit
-set-dns=trueand-set-dns=false.flutter test --no-pub --reporter expanded test/core/ffi/base_ffi_api_test.dart test/core/ffi/windows_exe_test.dart test/core/ffi/windows_msix_test.dart: 44 passed using process/native substitutes.git diff --check: passed. The tested Core files remained identical after incorporating the latest remote branch commit.Merge Danger
Door: two-way
Blast Radius: Runtime
Windows packages must include a desktop Core supporting
-set-dns=true|false. This branch also changes desktop window integration and App-generated DNS behavior.