Repository navigation
fix(ui): refresh latency settings summary on return - #268
Merged
Merged
Conversation
Contributor
Author
|
All 23 CI failures also reproduce on base commit 315603a in an isolated Windows run without this PR. They are pre-existing DNS assertion mismatches, unrelated to this latency-summary fix. Both new save/cancel regression tests pass in Linux CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saving a new latency-probe URL or timeout now updates the speed-test summary on the Xray page. Cancelling retains the saved values.
The regression tests mock the macOS capability channel. Existing DNS assertions now match managed TCP resolvers and
rewriteNetwork: tcp; explicit DNS and saved-configuration preservation checks remain intact.Evidence
After: Both save/cancel regressions pass with the production fix and an isolated native-channel mock.
Merge Danger
Door: Two-way
No data migration or persistence changes.
Blast Radius: UI