Skip to content

Remove the custom winget schema version restriction - #265

Merged
yiguodev merged 2 commits into
mainfrom
fix/winget-manifest-schema-26.11.2
Nov 6, 2026
Merged

yiguodev merged 2 commits into
mainfrom
fix/winget-manifest-schema-26.11.2

Conversation

@yiguodev

@yiguodev yiguodev commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Komac emits manifest schema 1.28.0, but the release helper rejects every version except 1.12.0. Remove that custom version restriction and validate each file against Microsoft's official schema for its declared version.

- Require ManifestVersion == 1.12.0
- Always load Microsoft's 1.12.0 schema
+ Load the official schema for each declared ManifestVersion

Evidence

  • Before: Update winget #20 failed with Expected manifest schema 1.12.0 after successful generation.
    After: Update winget #21 passed with three actual schema 1.28.0 manifests, validated against Microsoft's schemas.
  • 9 focused unit tests pass. Six integration fixtures based on existing manifests and verified release assets pass the official 1.12.0 / 1.28.0 JSON schemas.
  • Both installer URLs and SHA-256 values match the release assets. Package identity, architectures and OneXray installation policy remain checked.

Merge Danger

Door: two-way

Blast Radius: publishing

Affects WinGet manifest schema selection in the release helper.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T13:11:07.699025Z 1dd58b6 New commits
🔒 Security Review ✅ Completed 2026-11-05T13:13:01.252606Z 1dd58b6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@yiguodev yiguodev changed the title Fix winget validation for current Komac schema versions Remove the custom winget schema version restriction Nov 5, 2026
@yiguodev
yiguodev merged commit a5b88b2 into main Nov 6, 2026
2 checks passed
@yiguodev
yiguodev deleted the fix/winget-manifest-schema-26.11.2 branch November 6, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant