Skip to content

Fix Android draft uploads and reuse hosted showcase images - #264

Merged
yiguodev merged 1 commit into
mainfrom
dev-26.11.2-4
Nov 5, 2026
Merged

yiguodev merged 1 commit into
mainfrom
dev-26.11.2-4

Conversation

@yiguodev

@yiguodev yiguodev commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix Google Play's rejection of internal draft uploads and reuse localized website showcase images in the three READMEs.

 Android internal draft upload
- changes_not_sent_for_review: true
+ skip metadata, images, screenshots and changelogs
 README showcase images
- seven local PNGs
+ one hosted composition per language

Keep automatic parameter rescue disabled. Document the required Play Console checks before uploading the binary and saving store content.

Evidence

  • Before: The Play API rejected the internal draft edit when changesNotSentForReview was set.
    After: The rejected option is removed; track: "internal", release_status: "draft" and disabled automatic rescue are preserved. Ruby syntax validation passes.
  • Before: The READMEs used local PNG copies alongside unused screenshots.
    After: All three hosted PNG URLs return successfully and match the expected image hashes; no references to the removed local images remain.
  • Previously verified for the Fastlane change: lane-argument probe passed; build-script tests: 34 passed, 1 skipped.
  • git diff --check passes. A live Play upload has not been rerun.

Merge Danger

Door: two-way

A revert restores the upload arguments and local images.

Blast Radius: release

Upload skip flags do not isolate changes already pending in Play Console; a normal API commit can include those changes. The updated instructions require checking for pending changes and active reviews before uploading. README images now depend on the stable hosted PNG URLs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T10:44:24.010817Z 7608ba1 PR opened
🔒 Security Review ✅ Completed 2026-11-05T10:47:04.468266Z 7608ba1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@yiguodev
yiguodev merged commit 555e2b7 into main Nov 5, 2026
1 check passed
@yiguodev
yiguodev deleted the dev-26.11.2-4 branch November 5, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant