Repository navigation
Fix Android draft uploads and reuse hosted showcase images - #264
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Google Play's rejection of internal draft uploads and reuse localized website showcase images in the three READMEs.
Keep automatic parameter rescue disabled. Document the required Play Console checks before uploading the binary and saving store content.
Evidence
changesNotSentForReviewwas set.After: The rejected option is removed;
track: "internal",release_status: "draft"and disabled automatic rescue are preserved. Ruby syntax validation passes.After: All three hosted PNG URLs return successfully and match the expected image hashes; no references to the removed local images remain.
git diff --checkpasses. A live Play upload has not been rerun.Merge Danger
Door: two-way
A revert restores the upload arguments and local images.
Blast Radius: release
Upload skip flags do not isolate changes already pending in Play Console; a normal API commit can include those changes. The updated instructions require checking for pending changes and active reviews before uploading. README images now depend on the stable hosted PNG URLs.