refactor: add project application service seam - #99
Merged
xiayh17 merged 36 commits intoAug 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectQueryServiceandProjectMutationServiceseams inrho-store;Stack dependency
This PR is stacked on Phase 2 PR #76 at exact head
12860008381910d8280d277ea1006ab04746b281. It should be rebased ontomainafter #76 merges; no #76 source is reimplemented here.Governance
Owning contract:
docs/plans/active-2026-08-20-project-application-service-seam-spec.md(APP-SVC1, D2/R2). RawStoreremains the sole persistence authority. No schema, migration, frontend/mock shape, public protocol, new mutation, version, NEWS, or release change.Local validation
cargo test -p rho-store --locked --no-fail-fast: 153 passed;cargo test -p rho-desktop --locked --no-fail-fast: 204 passed, one existing opt-in Keychain smoke ignored;cargo test --workspace --locked --no-fail-fast: passed;cargo build --workspace --locked: passed;cargo fmt --all -- --checkandgit diff --check: passed;rho.bridge: 575 passed;rho.agent: 120 passed.Hosted validation
Exact source head
69f073bbf00e711f7ae936840fce1528ed0cb12a:32361870469: passed;32362297716: all six macOS/Ubuntu/Windows stable and Rust 1.88 legs passed, including packaged app smoke on every stable leg.Independent review resolved unscoped Plot clearing, unused wrapper methods, incomplete query/mutation coverage, blank project identity, and stale direct-Store contract assertions.