fix(client): blank optional AutoForm fields no longer force a password - #54
Merged
Merged
Conversation
AutoForm always submitted every field's raw string value, so an untouched optional field like AccountPage's "set a password" box sent '' rather than undefined. Zod's PasswordSchema.optional() only skips validation on undefined, so '' still hit min(8) and blocked every account save (bio-only edits included) behind a password the user never asked to set — worse for Google OAuth accounts, which have no password to type at all.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoFormsubmitted every field's raw string, so an untouched optional field (e.g. AccountPage's "set a password" box) sent''instead ofundefined..optional()only skips validation onundefined, so''still hitPasswordSchema.min(8)and blocked every account save — bio-only edits included — behind a password field. Worse for Google OAuth accounts, which have no password to enter at all.undefined, not''.Test plan
npm run test -- apps/client/src/components/patterns/AutoForm.test.tsx— added a regression test for the exact bugnpm run test— full suite, 476 passing