Remove Facebook OAuth, keep Google-only - #52
Merged
Conversation
Extends the already-shipped PATCH/DELETE /api/v1/users/:id API with username and email editing, current-password verification before a password change, OAuth accounts setting an initial password, and cascade-deleting a user's posts/comments/likes on account deletion. Deletion requires re-entering the password (or, for OAuth-only accounts, typing the username) as confirmation. Adds the client side that never existed for this API: /account (self, editable) and /users/:id (anyone, read-only), reached by making every username byline in the app clickable.
Password fields (login, signup, account update/delete) were plain text inputs showing the value in the clear, and AutoForm rendered labels as raw camelCase schema keys (e.g. "currentPassword"). Adds a shared PasswordInput with a show/hide toggle used everywhere a password is entered, and humanizes AutoForm's field labels.
ChatRoom.test.tsx's render wrapper was typed as typeof rtlRender, whose generic overloads don't survive a plain arrow-function assignment. Typed it explicitly against ReactElement/RenderOptions instead. The cascade-delete test's postService.create calls were missing tags, required by CreatePost's inferred (post-default) type even though the schema defaults it at parse time.
Facebook was scaffolded but never wired up in production (Facebook's HTTPS redirect requirement made it poor value for a demo), and the team has decided not to build it out. Strips the passport-facebook strategy, the facebookId model field, provider-config plumbing (env vars, compose, .env.example), and every code/doc/test reference, while keeping Google OAuth and its account-linking security behavior unchanged. package-lock.json regenerated via npm install after dropping passport-facebook / @types/passport-facebook.
YonatanHen
force-pushed
the
dev/remove-facebook-oauth
branch
from
July 31, 2026 15:29
5bef746 to
aa44952
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Facebook OAuth was scaffolded but never wired up in production (the redirect-HTTPS requirement made it poor value for a demo). The team has decided not to build it out at all, so this strips it entirely: the
passport-facebookstrategy, thefacebookIdmodel field, provider-config plumbing (env vars, compose,.env.example), and every code/doc/test reference — while keeping Google OAuth and its account-linking security behavior unchanged.Stacked on #51 (
dev/user-account-management) — this branch was created on top of it, so this PR's commit history includes that PR's commit until #51 merges. Only the second commit (chore(oauth): remove Facebook sign-in, keep Google-only) is new here; please merge #51 first, or review just that commit.Test plan
npm run test— 475 passing (server + client)facebook/Facebookreference anywhere in the repo (package-lock.jsonregenerated vianpm install)