fix(auth): route OAuth callback URLs through the RENDER_EXTERNAL_URL fallback - #50
Merged
Merged
Conversation
…fallback Google sign-in was rejecting every attempt in production with redirect_uri_mismatch. The server was sending Google a callback of http://localhost:5173/api/v1/auth/google/callback instead of the real onrender.com URL. Root cause: registerOAuthStrategies was built from `process.env.PUBLIC_ORIGIN ?? 'http://localhost:5173'` directly in routes/v1/auth.ts, bypassing the RENDER_EXTERNAL_URL fallback entirely — that logic only lived inside env.ts's resolveFileBackedSecrets(), which auth.ts never called. With PUBLIC_ORIGIN correctly left unset on Render (per its own sync: false / "only needed for a custom domain" contract), the raw process.env read was undefined and fell straight to the hardcoded default. Extracted resolvePublicOrigin() as a standalone function in env.ts, independent of the full EnvSchema, and call it from auth.ts. It has to be standalone rather than routed through loadEnv(): the full schema also requires MONGODB_URI/SESSION_SECRET, which the test harness never populates in process.env directly (those are passed to buildTestApp as explicit options), so calling loadEnv() at OAuth-route time broke five existing tests that don't need any of that to check a provider flag. New regression test builds the actual test app with GOOGLE_CLIENT_ID set, PUBLIC_ORIGIN unset, and RENDER_EXTERNAL_URL set to a fake onrender.com URL, then asserts the real redirect_uri query param on the Google redirect resolves to that URL, not localhost — reproducing the exact failure from production. Lives in its own file: configuredProviders() caches its result in a module-level singleton on first call, and oauth.test.ts's own tests are already the first callers in that module instance with no credentials configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Google sign-in being rejected in production with
redirect_uri_mismatch— the server was sending Googlehttp://localhost:5173/api/v1/auth/google/callbackinstead of the real onrender.com URL.Root cause
registerOAuthStrategiesinroutes/v1/auth.tsbuiltPUBLIC_ORIGINfrom rawprocess.env.PUBLIC_ORIGIN ?? 'http://localhost:5173'— completely bypassing theRENDER_EXTERNAL_URLfallback, which only lived insideenv.ts'sresolveFileBackedSecrets(). WithPUBLIC_ORIGINcorrectly left unset on Render (per its own contract — "only needed for a custom domain"), the raw read wasundefinedand fell straight to the hardcoded localhost default. Confirmed live by hittingGET /api/v1/auth/googleon the deployed service and reading the actualredirect_uriin the resultingLocationheader.Fix
Extracted
resolvePublicOrigin()as a standalone function, independent of the fullEnvSchema, and call it fromauth.ts. It can't go throughloadEnv()directly — that also requiresMONGODB_URI/SESSION_SECRET, which the test harness passes tobuildTestAppas explicit options rather than populating inprocess.env, so routing throughloadEnv()at request time broke five existing tests.Test
New regression test builds a real test app with
GOOGLE_CLIENT_IDset,PUBLIC_ORIGINunset, andRENDER_EXTERNAL_URLset to a fake onrender.com URL, then asserts the actualredirect_uriquery param Google would receive resolves to that URL — reproducing the exact production failure. Lives in its own file rather than insideoauth.test.ts, becauseconfiguredProviders()caches its result in a module-level singleton on first call, and that file's own tests are already the first callers with no credentials configured.npm run test— 458/458 pass, 52 files.npm run typecheckclean.Next step
Once this merges to
staging, it needs to reachmasterand redeploy to Render before Google sign-in actually works in production —staging→masterPR #49 is already open and will pick this up.