feat(product): formalize product data contract and decouple from assessments#23359
Conversation
FAMarfuaty
force-pushed
the
657-api-migration-formalize-the-product-customdata-contract-and-decouple-producttype-from-the-e-commerce-assessments
branch
from
579fc01 to
db542ef
Compare
FAMarfuaty
changed the base branch from
trunk
to
634-api-migration-define-a-serializable-paperkeyphrase-input-contract-for-non-wordpress-consumers
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…input-contract-for-non-wordpress-consumers' of github.com:Yoast/wordpress-seo into 657-api-migration-formalize-the-product-customdata-contract-and-decouple-producttype-from-the-e-commerce-assessments
Adds a typed, validated productData field to the PaperDTO input contract (productData.js / productDataSchema), wired through toPaper onto Paper.productData. The narrower that applies it at the consumption boundary, normalizeProductData, lives in a separate zod-free module that the assessments import directly, keeping zod out of the core analysis bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
FAMarfuaty
force-pushed
the
657-api-migration-formalize-the-product-customdata-contract-and-decouple-producttype-from-the-e-commerce-assessments
branch
from
d3001bc to
7c3c7f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #