Repository navigation
fix: repair browser OAuth consent and callback redirects - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the production OAuth error
Invalid consent form. Reload the page and try again.when users click Allow or Cancel in a real browser.The HTML used
Referrer-Policy: no-referrer, which makes native form POSTs sendOrigin: null; the server correctly rejected that origin. After this rejection is fixed, Chromium also blocks the OAuth callback redirect underform-action 'self'.Use
strict-originfor consent/connection-management HTML so POSTs preserve Origin without disclosing URL paths/query parameters. Permit only the transaction's registered callback origin in consent's form-action directive. OAuth redirects still use no-referrer; the exact-origin and cookie/form CSRF checks are unchanged.Validation:
Origin: null, HTTP 403.