Repository navigation
修复 goal-weights 合并后的 e2e 失败 - #33
Merged
Merged
Conversation
- Manual boards keep the 我能解释 seal (weight-aware mastery only for weighted AI cards) - Update e2e tests to goal-weights behavior: 第 n 站 label, new recheck toast, default weight on import/restore, click title past weight footer - Skip probe-entry and two-wrong 卡住了 tests superseded by spec-v2 - goal-weights screenshots default to test-results (CI has no /workspace)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #32（goal-weights）合并后 CI 的 e2e 有 17 条失败。原因和修改如下：
代码修复（1 处）
app.spec的掌握度用例、「走一遍」用例）。goal-weights 让所有卡默认weight: background，而cardMastered只认 core/hard，所以手动画板的掌握标记被吞掉了。现在只有带权重操作的 AI 卡按权重算掌握，手动画板继续用「讲清楚 = 盖章」。测试跟上新行为
flow-p2稍后：站号文字从「4」改成了「第 4 站」。flow-p2浅印复查：提示语去掉了「4 拍」，改成「这一站排在下一步之后…」。transfer/electron-transfer：导入或恢复时 schema 会补上默认weight: background，测试改为按这个预期比对。sessions：在卡上提问会让卡升一级，卡面多出权重区，所以改成点卡片标题来重新打开对话。goal-weights：截图原来写到/workspace/...，CI 上没有这个目录。现在默认写到test-results/goal-weights-shots，也可以用GOAL_SHOTS指定。暂时 skip（spec-v2 已替代，需要确认）
flow-p2「摸底 v2」：新问题现在直接进入聊天式开场，不再进摸底。flow-p2「答错两次卡住了」：第一次答错就会升级权重，旧的三个出口走不到了。本地结果：两套 tsc 通过，vitest 469/469，build 通过，完整 e2e 127 通过、0 失败（56 条 skip，包括仅限 macOS 的用例）。