Repository navigation
feat(diagnostics): add scrollable problems popover and click-to-jump navigation - #24
Merged
Merged
Conversation
…navigation - Add interactive button on status bar error and warning counts with hover wash - Introduce DiagnosticsListView scrollable popover displaying errors, warnings, line/col badges, and sources - Support click-to-jump navigation centering target line, selecting range, and flashing standard emphasis highlight - Make DocumentDiagnostic conform to Identifiable with deterministic id calculation - Cover diagnostic sorting and Identifiable determinism with unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the user requirement for interactive diagnostic inspection and editor jump navigation:
DiagnosticsListView, a scrollable popover displaying all diagnostic errors, warnings, line/column coordinates (Ln X, Col Y), error messages, and LSP sources (e.g.,gopls,sourcekit-lsp).DocumentDiagnosticconform toIdentifiablewith a deterministic identifier.Key Changes
StatusBarView.swift, transformed static count text into an interactive button with hover states.DiagnosticsListView.swift):AppState.swift, addeddiagnosticJumpRequestandjumpTo(diagnostic:in:).CodeEditorView.swift, handles jump requests by delegating toLSPTextViewCoordinator.LSPTextViewCoordinator.swift,jumpTo(range:)sets the selection, centers the viewport viascrollToRange(range, center: true), makes the text view first responder, and flashes anEmphasishighlight.swift-format lintandscripts/build-app.shapplication bundle build.Testing & Verification
swift testpasses (125 tests across 34 suites)xcrun swift-format lint --strictclean (0 warnings)scripts/build-app.shcompletes successfully with valid code signature