Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORE-02 clears the five development dependency advisories that fail the root CI audit on main at e195ff7. The current audit on 2026-10-18 reproduced three critical, one high, and one moderate advisory; the production-only audit already reported zero.
Only pnpm-lock.yaml and pnpm-workspace.yaml change. Package manifests, direct parent versions, pnpm 11.22.0, public APIs, runtime dependencies, and publication behavior are unchanged. No publication changeset is needed for this development tooling fix.
Locked changes and primary advisory sources:
oxfmt@0.61.0>tinypool: 2.1.2override avoids a formatter migration. Its adjacent comment says to remove it after upgrading this repo's oxfmt to a version requiring tinypool >=2.1.2.All affected paths are development tooling, verified with pnpm why. No production exploit has been established in this repository. The three unconstrained transitives were refreshed with pinned pnpm using existing declared ranges; no broader parent upgrades were needed.
Current revision:
0fcc04d547f79a2f2a0bb90e852927a487ee727e. The follow-up changes only the override comment in pnpm-workspace.yaml to clarify that removal depends on this repo upgrading oxfmt. It retains the note that oxfmt 0.61.0 pins vulnerable tinypool 2.1.0. The lockfile is byte-for-byte identical to reviewed headaa2361532c26201c7c5298ec0c433aaebefe2129; overrides, dependency versions, and behavior are unchanged.Focused follow-up validation on Windows, Node v24.19.0 and pnpm 11.22.0, all exit 0:
pnpm install --frozen-lockfile: installed tooling in the fresh isolated checkout without changing the lockfilepnpm run fmt:check: 182 files passgit diff --checkaa2361532c26201c7c5298ec0c433aaebefe2129: identicalFull audits, lint, types, runtime tests, coverage, and build were not rerun for this comment-only revision. The following full-suite results belong to prior head
aa2361532c26201c7c5298ec0c433aaebefe2129, independently repeated by the Tests reviewer on Windows, Node v24.19.0 and pnpm 11.22.0, all exit 0:pnpm install --frozen-lockfilepnpm auditandpnpm audit --prod: zero advisories, without filtering or ignorespnpm run fmt:checkpnpm run lint: ten warnings in unchanged test files, no errorspnpm run test:types: all three packages passpnpm run test: 65 files, 340 passed, five existing TODOspnpm run coverage: same test totals; statements 100%, branches 100%, functions 96.42%, lines 100%pnpm run build: all three package builds pass, including publint and attw with the existing esm-only profilegit diff --checkLimits: main's known CORE-01 gap remains: ordinary tests do not compile the .spec.ts type assertions. Passing these baseline checks does not fix or validate type discovery or the enum assertion exposed by it. No PR16/PR17 patches were applied and no cumulative integration run was performed. Build output retains existing experimental TypeScript/Vitest notices, the types package's CJS warning ignored by esm-only, and Turbo's warning that the types build has no output files. GitHub push still reports an alert on the unchanged default branch; the full audit of this branch is clean. Linux Validate passed at prior head aa2361532c26201c7c5298ec0c433aaebefe2129, including frozen installation, formatting, lint, types, tests, coverage, build, and full audit. Independent Security and Tests reviews completed at that same SHA with no blocking findings; this comment clarification addresses the sole low-severity Security nit, CORE02-F1. Those reviews and the Linux result apply to the prior SHA, not the current revision. No CI outcome is claimed for the current revision; HQ retains final disposition.