Repository navigation
Conversation
🦋 Changeset detectedLatest commit: e1ce15e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YLfjuk
commented
Oct 20, 2026
| "@ylfjuk/core": patch | ||
| --- | ||
|
|
||
| BREAKING CHANGE: remove `Enum.toTuple`, its `enumToTuple` alias, and the otherwise empty `Enum` namespace from `@ylfjuk-core/utils` and the `@ylfjuk/core` umbrella re-exports. Imports of these APIs must be removed. |
Owner
Author
There was a problem hiding this comment.
Suggested change
| BREAKING CHANGE: remove `Enum.toTuple`, its `enumToTuple` alias, and the otherwise empty `Enum` namespace from `@ylfjuk-core/utils` and the `@ylfjuk/core` umbrella re-exports. Imports of these APIs must be removed. | |
| BREAKING CHANGE: remove `Enum.toTuple`, its `enumToTuple` alias, and the otherwise empty `Enum` namespace. Imports of these APIs must be removed. |
they shouldn't reference each other in their changelogs
YLfjuk
commented
Oct 20, 2026
Comment on lines
+19
to
+22
| ## Migration | ||
|
|
||
| BREAKING CHANGE: the `Enum` namespace, `Enum.toTuple`, and `enumToTuple` re-exports have been removed. Use `Object.values` for an array, or define an explicit tuple when positions matter. See the [migration guide](../utils/README.md#migrate-from-enumtotuple) for examples and the ordering and duplicate-value limitations. `UnionToTuple` remains public with unspecified, unstable element order. | ||
|
|
Owner
Author
There was a problem hiding this comment.
defer to the docs site issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Enum.toTuple, itsenumToTuplealias, and the otherwise emptyEnumnamespace from@ylfjuk-core/utilsand the@ylfjuk/corere-exports. The implementation castObject.valuesto a tuple whose positions could disagree with runtime order and whose length could omit duplicate values.The utils README migration guide uses
Object.values(enumLikeObject)for arrays and an explicitas consttuple when exact positions matter.UnionToTupleremains public, with an unspecified, unstable order warning and an example showing membership and length.UnionToTupleordering and duplicate collapse. The example names areNameandNameTuple.e195ff7d9aca4e702b098744a52d5ca29bd3e9cc. This is independent of CORE-01 and intended to land before CORE-01 is rebased. No CORE-01 changes are included.Validation of revision
e1ce15e5570e5d3dc0623595f748c35b4ff973e3:pnpm install --frozen-lockfile,pnpm run fmt:check,git diff --check, andpnpm exec changeset statuspassed. The release plan remains exactly three patches: types, utils, and core.Previous validation of revision
d69f6940c346e6b6f1c9e4f78834bf46402d1f89:pnpm install --frozen-lockfile,pnpm run fmt:check,git diff --check, andpnpm exec changeset statuspassed. The release plan still contains exactly three patches.pnpm exec turbo run test:types --filter=@ylfjuk-core/types --force,pnpm --filter @ylfjuk-core/types exec publint, andpnpm --filter @ylfjuk-core/types exec attw --pack --profile esm-onlypassed. attw's CommonJS resolution is excluded by the repository's ESM-only profile.--ignoreConfig --noEmit --strict --target ES2024 --allowImportingTsExtensionspassed using both ESNext/bundler and NodeNext/NodeNext. The fixture imports the current source public entry point and checks membership, length, rejection of an invalid length, duplicate collapse, array inference, and exact readonly-tuple inference. Node runtime checks confirmed duplicate preservation.Enum,toTuple,enumToTuple, or./enumreferences. UnrelatedMappedEnumtest locals and historical/migration documentation remain.Earlier validation at
c0a2a5a1fe337f9001e67e4c93f9e3280f9bdd44:25fe42b7412f6b63ff017577cefc96623ae073e9: test:types, test, test:discovery, and coverage passed with 652 passes, nine TODOs, and no type errors. Those results cover the earlier heads, not this documentation revision.Limits: the full runtime/build/coverage suite was not repeated for these documentation revisions. Main's existing test configuration does not compile .spec.ts assertions; the focused compiler fixture checks the examples independently. The stale exact-order test remains for CORE-01. Existing dependency audit failures belong to CORE-02; dependencies and lockfile are unchanged. HQ owns current-head independent re-review and combined validation.