Repository navigation
feat/forge/accounts - #41
Merged
Merged
Conversation
Accounts and sign-in are per forge: settings.accounts[forgeId] (migrated from token/githubAuth), tokenFor()/ensureFreshToken(f), one device flow driven by each adapter's `auth`, and the Rust command oauth_post (limited to OAUTH_URLS) with forge_build_config replacing the github_* commands. The account menu has a section per forge. The git commands take host/owner/repo (git_link_github → git_link_remote); tokens only go to hosts in FORGE_HOSTS (x-access-token for GitHub, oauth2 for GitLab), remotes are recognised in any URL form, GitLab subgroups included, and messages name the forge. src/forge/gitlab.js implements the forge interface for gitlab.com: files through the API, merge requests (!N) and their diffs, comparisons, file discussions as review comments, kivi issues, member projects for the gallery and the home lists. Repositories are kept by key (owner/repo on GitHub, gitlab:group/project on GitLab); the gallery, pull/merge request and issue lists gather every forge. UI text names the forge (forge.words). Tests: tests/gitlab.js (mocked gitlab.com, in CI), forge interface and sign-in URL checks in tests/review.js, Rust tests for forge URLs and token hosts, an ignored clone_gitlab_over_https. Screenshots regenerated where the wording changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Sign in opens a forge chooser (GitHub, GitLab) with each forge's logo, loaded from the forge at run time (KiVi ships no forge logos: GitLab's artwork is CC BY-NC-SA); offline the tiles show only the names. The chooser carries the trademark line. - One forge signed in at a time: a sign-in replaces any other account (the code step says so); settings holding several keep the newest. - Every forge card shows its forge's tag, GitHub included, and so does a local card linked to a forge. - Remote project… and Link to remote… have no forge picker: the address decides, a shorthand goes to the forge signed in to, group/sub/project to GitLab (parseRepoInput), shown under the box as it's typed; one text for both forges. - A merge request from a fork shows its branch as namespace:branch. - README, user guide and CLAUDE.md describe GitHub and GitLab; screenshots regenerated where the gallery changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…al diff hint - GitHub's rate-limit message says "sign in to GitHub", like the rest of the UI. - A refused GitHub push or fetch says "sign in to GitHub in KiVi", like GitLab's. - The diff pickers' hint for a local copy says "like a pull or merge request". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.