Repository navigation
Conversation
|
Hi @rudalabs, thank you very much for your interest and contribution to KiVi. Would it be possible to split this pull request into several separate pull requests:
I would like to also hear about integrated terminal idea more, how KiVi will benefit from it? |
|
Integrated Development environments like CLion, VSCode etc. all give the user the possibility to open a terminal as part of the IDE without it being a separate window. Now I know this is not an IDE but a lot of nerds are used to using the terminal for all commands related to engineering work ( |
- Terminal panel at the bottom of every desktop page (header button or Ctrl+`): the user's shell on a pty (terminal.rs, libc posix_openpt), drawn by a small DOM-free emulator (vt.js); reattaches across pages. - The shell starts with default signal handling; closing hangs up the process group, then kills it 2 s later; the terminal ends when the shell exits, even if something it started still holds the pty. - Unix only: on Windows the commands report that the terminal isn't available. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
986dcb0 to
350168e
Compare
|
I had Claude split this into 2 MRs like you asked. |
# Conflicts: # src/desktop/account.js
The terminal on its own. The folder chooser and gallery zoom moved to #40.
Depends on #40: this branch is built on top of it, so until #40 is merged the diff here also shows its commits. Only the last commit, "Integrated terminal", belongs to this PR.
Integrated terminal
$SHELLon a pseudo-terminal (src-tauri/src/terminal.rs,posix_openptthroughlibc, no pty crate), started in the open project's folder (folder=/local=) or the home folder, with the AppImage environment removed.src/desktop/vt.js): colours (16/256/true colour), cursor movement, scroll regions, the alternate screen (less, vim, top), bracketed paste and 5,000 lines of scrollback.exitcloses the panel.Testing
cargo test --locked --lib: 23 passed, 3 ignored (the ones needing the network or an installed KiCad), including a test that runs a shell on the pty (window size, starting folder, controlling terminal, ending it).The new direct dependency
libc(Unix) was already in the tree through Tauri, soCargo.lockgains no packages.🤖 Generated with Claude Code