Skip to content

refactor(forge): move all GitHub API code into a GitHub adapter - #37

Merged
XyleMora merged 1 commit into
mainfrom
refactor/forge/github/adapter
Nov 8, 2026
Merged

XyleMora merged 1 commit into
mainfrom
refactor/forge/github/adapter

Conversation

@XyleMora

@XyleMora XyleMora commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Every GitHub request (REST, GraphQL, raw files, search), the PR/commit comparison, review comments, issues and github.com links now live in src/forge/github.js. The rest of the app reaches GitHub only through the forge interface in src/forge/index.js (JSDoc typedefs plus the FORGES registry) and gets forge-neutral shapes back, so other forges (GitLab, Gitea, ...) can be added as new adapters.

  • src/review.js keeps only the comment marker and thread shape; src/issues.js is folded into the adapter (GitHubIssues) and review.js
  • sources carry source.forge; page hashes use forge.hashKey (gh=)
  • pr-files.js takes neutral ChangedFiles
  • tests/review.js checks every forge implements the interface, spec routing and search query splitting; tests/diff.js goes through the adapter
  • CLAUDE.md and README layout updated

Not forge-neutral yet: tokens and sign-in, the Rust git commands, UI wording.

Every GitHub request (REST, GraphQL, raw files, search), the PR/commit
comparison, review comments, issues and github.com links now live in
src/forge/github.js. The rest of the app reaches GitHub only through the
forge interface in src/forge/index.js (JSDoc typedefs plus the FORGES
registry) and gets forge-neutral shapes back, so other forges (GitLab,
Gitea, ...) can be added as new adapters.

- src/review.js keeps only the comment marker and thread shape;
  src/issues.js is folded into the adapter (GitHubIssues) and review.js
- sources carry `source.forge`; page hashes use `forge.hashKey` (gh=)
- pr-files.js takes neutral ChangedFiles
- tests/review.js checks every forge implements the interface, spec
  routing and search query splitting; tests/diff.js goes through the adapter
- CLAUDE.md and README layout updated

Not forge-neutral yet: tokens and sign-in, the Rust git commands, UI wording.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XyleMora
XyleMora merged commit 2521f33 into main Nov 8, 2026
6 checks passed
@XyleMora
XyleMora deleted the refactor/forge/github/adapter branch November 8, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant