Slim CI to lint+build for the deprecation shim - #35
Merged
Merged
Conversation
The 2.1.0 shim deleted its test suite, but CI still ran a PostgreSQL/Django pytest matrix (every job failed) and the lint job tripped E402 on the re-export sitting after the deprecation warning. - Move the re-export to module top (fixes ruff E402); the warning still fires. - Drop the test-pr/test-full matrix from ci.yml — nothing to exercise here. - Remove the dangling pytest config (pointed at the deleted tests.django_settings) and the now-unused pytest dev dependencies. CI is now lint (ruff + mypy) + build, right-sized for a frozen shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets CI green again. After 2.1.0 turned the package into a re-export shim, CI was red on every branch for two reasons:
ruff checktripped E402: thefrom django_pg_utils.locks import …re-export sat after thewarnings.warn(...)call.tests/, butci.ymlstill ran a full PostgreSQL × Django × psycopgpytestmatrix, andpyproject.tomlstill pointedDJANGO_SETTINGS_MODULEat the deletedtests.django_settings. Every job failed.Changes
src/django_pglocks/__init__.py— move the re-export to module top (fixes E402). TheDeprecationWarningstill fires on first import..github/workflows/ci.yml— droptest-pr/test-full; keeplint(ruff + mypy) +build. A frozen shim that only re-exports has nothing to exercise.pyproject.toml— remove the dangling[tool.pytest.ini_options]and the unused pytest dev dependencies.Verified locally
ruff check✅ ·ruff format --check✅ ·mypy✅ ·uv build✅ ·import django_pglocksstill warns and resolvesadvisory_locktodjango_pg_utils.locks._sync(i.e. from django-pgware).Note: no effect on the published 2.1.0 artifact — this is repo hygiene only.