Monitor all files, use file mask, include files, bug fixes.#188
Open
ershov wants to merge 1 commit intoXfennec:masterfrom
Open
Monitor all files, use file mask, include files, bug fixes.#188ershov wants to merge 1 commit intoXfennec:masterfrom
ershov wants to merge 1 commit intoXfennec:masterfrom
Conversation
Author
|
@Xfennec Hi, May I ask you to review this PR? It fixes a couple of crashes and adds some useful options. I know it's rather big, so I'm open to any discussion to explain what it does or how to break it up into smaller - more manageable - pieces. |
Author
|
@Xfennec Hey can I do anything to help review this PR? |
Owner
|
Hi @ershov, First of all, thanks, this is some interesting changes. This is a big PR indeed. I currently have limited time to dedicate to the project, so unfortunately I'll have to ask you to wait a bit. Sorry about that. Of course, if you think that you can split your work in smaller chunks (it's not always easy), go ahead, it will make my day easier :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs and adds some useful features: