Open
Conversation
Owner
|
I added this PR on my todo list… and never got time to unstack it. Sorry for that! The issue with the current patch is that removing the It currently sort of works because the compiler does not reallocate between call, but it's an happy accident 😅 . Making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the issue in #146 with the process count limit being hit. This PR defaults to 32 and lets the user supply their own value.
I'm unsure of the implications of making
old_resultsno longer static, but changing it allows the user-supplied variable to be used instead.Usage:
Another solution might be to scan for the processes first to get an upper count, before going on to fill the array with the process info, to not need a count supplied with >32 processes.