Skip to content

InfluxDB Health Check#704

Merged
sungam3r merged 96 commits into
Xabaril:masterfrom
maikebing:HealthChecks_InfluxDB
Dec 24, 2022
Merged

InfluxDB Health Check#704
sungam3r merged 96 commits into
Xabaril:masterfrom
maikebing:HealthChecks_InfluxDB

Conversation

@maikebing

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread build/dependencies.props Outdated
Comment thread build/dependencies.props Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/README.md Outdated
@maikebing

Copy link
Copy Markdown
Contributor Author

Hi, Do you have time to review this code? @sungam3r

Comment thread src/HealthChecks.InfluxDB/InfluxDBHealthCheck.cs Outdated
Comment thread src/HealthChecks.InfluxDB/README.md Outdated
Comment thread src/HealthChecks.InfluxDB/README.md Outdated
Comment thread src/HealthChecks.InfluxDB/README.md Outdated
Comment thread src/HealthChecks.InfluxDB/README.md Outdated
Comment thread test/HealthChecks.InfluxDB.Tests/Functional/InfluxDBHealthCheckTests.cs Outdated
@sungam3r sungam3r added this to the V7 Release milestone Dec 23, 2022
@sungam3r

Copy link
Copy Markdown
Collaborator

Setup InfluxDB step hangs.

@maikebing

Copy link
Copy Markdown
Contributor Author

Setup InfluxDB step hangs.

I'm trying to fix this.

@maikebing

maikebing commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

@maikebing

Copy link
Copy Markdown
Contributor Author

Since the script for influxdata/influxdb-action does not work with the new influxdb 2.6.0 package, the script has been fixed and the PR has been opened , influxdata/influxdb-action#3

dotnet build --no-restore ./src/HealthChecks.InfluxDB/HealthChecks.InfluxDB.csproj &&
dotnet build --no-restore ./test/HealthChecks.InfluxDB.Tests/HealthChecks.InfluxDB.Tests.csproj
- name: Setup InfluxDB
uses: maikebing/influxdb-action@v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Then ping back when fix will be merged in official repo. I will review today and merge.

Comment thread .github/workflows/healthchecks_influxdb_ci.yml Outdated
Comment thread docker-compose.yml
- "8222:8222"
- "6222:6222" No newline at end of file
- "6222:6222"
influx:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used on CI?

@sungam3r sungam3r merged commit d759df1 into Xabaril:master Dec 24, 2022
@sungam3r

Copy link
Copy Markdown
Collaborator

@maikebing Thanks. Almost 2-year journey.

@maikebing

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and merging!

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants