Differences between upstream (red) and UKHSA's fork (green)#1337
Draft
kathryn-dale wants to merge 885 commits into
Draft
Differences between upstream (red) and UKHSA's fork (green)#1337kathryn-dale wants to merge 885 commits into
kathryn-dale wants to merge 885 commits into
Conversation
Forms with APIM webhooks
patch: form iterations
* fix: use DISABLE_V8_COMPILE_CACHE=1 so the designer can build via docker (XGovFormBuilder#1363) * fix: MiniSummaryPageController change link issue (XGovFormBuilder#1360) * chore(ci): use GITHUB_TOKEN instead of GHCR_PAT for checkout action (XGovFormBuilder#1347) * Summary card button accessibility and consistency issues * The button was technically a link, which meant how it looked and how screen readers treated it was inconsistent. I have changed it so that it's a button that does a GET request to the page when clicked. * The word 'remove' has been changed to 'delete'. * The button text will now just say 'Add...' if there's only one entry, which is consistent with the functionality where you can't delete entries if only one is present. * Set base tag to Alpine and add symlink to fix SSL issue (XGovFormBuilder#1366) * feature: custom ConfirmationSessionTimeout per form setup (XGovFormBuilder#1359) * Don't capitalize the configured service name * patch: file upload errors (XGovFormBuilder#1351) * fix: avoid duplicate submit on normal summary (XGovFormBuilder#1371) * allow autocomplete options for email (XGovFormBuilder#1373) --------- Co-authored-by: Jen Duong <hi@jen.digital> Co-authored-by: calum-ukhsa <calum.hemphill@ukhsa.gov.uk> Co-authored-by: Trevor Rea <trevorrea@users.noreply.github.com> Co-authored-by: SullyK <68860309+SullyK@users.noreply.github.com> Co-authored-by: kitttang <katrina.tang@accenture.com>
…-error-message added confimation sesstion timeout to missing envs
Prefix Magic link record cache key Lowercase key fields
…ross_session_support feature: Magic link cross session support
patch: Fix magic link not working from last pr due to cache segmentation
…-mesage Feature - SRS specific - Grouping Personal Details for improved erros
…ontent Form Change - Edited Do you live with other people Page
…contact_details_error Micol/inserting new contact details error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differences between upstream (red) and UKHSA's fork (green)