docs(releases): mirror the v0.19.1 patch train - #44
Merged
Merged
Conversation
On a pull_request event github.ref is refs/pull/<n>/merge, so the old expression's single github.ref test never matched refs/heads/master and a PR whose BASE is master was graded against the sibling's develop. The corpus on master documents the released platform, so that is a wrong verdict: the v0.19.1 mirror PR failed on four citations of indexer files that live at src/ on master and moved under src/consensus/ on develop. The expression now also reads github.base_ref, which is empty on a push event and so leaves the push cases unchanged. A release/* head still reads its own branch, a push to master still reads master, everything else still reads develop. test/ci-sibling-ref-expression.test.js asserts all four cases by evaluating the literal expression read out of ci.yml, for every checkout step that names a repository, so a copy of the rule cannot drift from the rule the venue runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan