fix: PR #50 review feedback - cold-start XHS routing & verify glob - #60
fix: PR #50 review feedback - cold-start XHS routing & verify glob#60aq5115325-cyber wants to merge 2 commits into
Conversation
|
Thanks for picking up the review items from #50! The intent is exactly right, but this PR can't be merged as-is — a few things to sort out first: 1. 2. Suggested path: since #50 owns Happy to review again once it's down to a clean, minimal diff. 🙏 |
|
感谢你主动接手 #50 的 review 意见 @aq5115325-cyber —— 方向和判断都是对的。 关闭原因是这两处修复已经被 #50 自己覆盖了,我核对过:
加上这个分支现在跟 main 已经冲突,与其解冲突不如让 #50 单独收口,避免两个 PR 改同一片区域互相打架。 之前提的整文件重写(换行符 CRLF↔LF)问题值得记一下: 欢迎继续贡献。 |
Addresses both review issues from @Jooonnn on PR #50:
Fix 1: Cold-start XHS routing bug
Added Q1.2 follow-up question for short-text users to specify their target platform (xiaohongshu/weibo-x/other). Starter selection now checks both \enabled_perf_adapters\ (for existing users) and \short_text_platform\ (for cold-start users).
Fix 2: Verify script glob coverage
Shell syntax check find glob now includes \�dapters/script-extraction/*/run.sh\ to cover the whisper adapter.
See individual commits for full changes.