Repository navigation
i18n(zh-CN): Settings navigation, Expectations and Themes - #132
Merged
X4Applegate merged 1 commit intoOct 10, 2026
Merged
Conversation
`settings.section.*` — The Settings navigation itself — every section name and description `settings.expectations.*` — Post-apply checks: heading, rollback toggle and its help text `settings.theme.*` — The colour-theme option names `settings.*` (shared) — Settings heading, *Save … settings* button, saved/applied messages, nav aria label Data-only: web/i18n/zh-CN.json is the only file touched. The diff also carries the settings.default_language.auto wording fix from X4Applegate#131 (otherwise this snapshot would revert it). All the batch PRs change that same line to the same value, so they merge cleanly in any order.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i18n(zh-CN): Settings navigation, Expectations and Themes
What & why
Next batch of the
zh-CNcatalog: Settings navigation, Expectations and Themes, as a data-only change.Data-only:
web/i18n/zh-CN.jsonis the only file touched. No Go, template orJavaScript edits.
Scope
36 new keys:
settings.section.*settings.expectations.*settings.theme.*settings.*(shared)Catalog goes from 63 shipped keys to 99 keys (32% of English). The
rest stays English by design, so nothing breaks.
Merge order (please read)
This diff is a snapshot of the whole file, so besides its own 36 keys it
contains the
settings.default_language.autowording fix that #131 also carries(否则用英文 → 否则显示英文). Every batch PR sets that line to the same value, so they
merge cleanly in any order and none of them can silently revert it.
Checklist
go build ./...compilesgo test ./internal/i18n/ ./internal/server/ -run 'Translation|Catalog|Language|Locale'passesdocs/TRANSLATING.mdCHANGELOG.md/ version bump — left to you, as beforeNotes for reviewers
settings.save_sectionis 保存{section}设置: the placeholder takes the already-translated section label, so no space is inserted around it in Chinese.settings.expectations.help+_afterare split around the<em>holdingsettings.expectations.section_name; assembled it reads 在代理主机上定义的期望项(也就是它的期望项部分)会在每次配置同步后立即运行。TestSettingsNavigationMatchesTheEnglishCatalogpins on the English side.Verification — run against this exact file, in a Linux container (WSL):
exit=0— includingTestEveryCatalogMatchesEnglishKeysAndPlaceholdersandTestEveryTranslationKeyUsedExistsInEnglish. Same as #131.One note if you ever test on Windows: a plain checkout there fails
internal/caddy'sTestBuildProxyRouteGolden, because that test compares bytes andcore.autocrlfmakes thetestdata/*.jsongolden files CRLF on disk while thegenerated JSON is LF. It reproduces on an untouched
main, so it is unrelated to thisPR — it is just why the run above is documented as Linux.
The
pr2log of that run is kept locally if you want it pasted here.Catalog facts