Skip to content

S231 qual issues - #15

Merged
eschultink merged 3 commits into
mainfrom
s231-qual-issues
Aug 17, 2026
Merged

S231 qual issues#15
eschultink merged 3 commits into
mainfrom
s231-qual-issues

Conversation

@eschultink

Copy link
Copy Markdown
Member

Features

  • bucket logging option
  • bucket versioning option

Change implications

  • dependencies added/changed? yes

@eschultink
eschultink requested review from aperez-worklytics, davidfq and jlorper and a lite review from Copilot August 12, 2026 14:14
@eschultink eschultink self-assigned this Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds optional S3 bucket hardening/operability features to the module by allowing callers to enable export-bucket versioning and configure S3 server access logging.

Changes:

  • Added new input variables to control export-bucket versioning and access logging destination/prefix.
  • Added conditional aws_s3_bucket_versioning and aws_s3_bucket_logging resources to implement those options.
  • Documented new options in README and recorded them in the changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
variables.tf Introduces new inputs for bucket versioning and access logging configuration.
main.tf Adds conditional resources to enable S3 versioning and server access logging on the export bucket.
README.md Documents how to enable versioning and access logging via module inputs.
CHANGELOG.md Notes the new optional flags/inputs under Unreleased.
Suppressed comments (1)

README.md:113

  • Same issue as above: this snippet uses a hyphenated module name, but the README later references module.worklytics_export.... Prefer an underscore-only module name so references work consistently.
module "worklytics-export" {
  # ...
  aws_s3_access_log_bucket = aws_s3_bucket.access_logs.id
  aws_s3_access_log_prefix = "worklytics-export/"
}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated
Comment thread main.tf
Comment on lines +72 to +79
resource "aws_s3_bucket_versioning" "worklytics_export" {
count = var.enable_aws_s3_bucket_versioning ? 1 : 0

bucket = aws_s3_bucket.worklytics_export.id

versioning_configuration {
status = "Enabled"
}
eschultink and others added 2 commits August 17, 2026 10:44
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Bump required AWS provider for standalone S3 versioning/logging resources
- Matrix integration CI on ~> 5.0 and ~> 6.0 instead of ~> 3.0
- Note in CHANGELOG that the next release should be 1.0.0 (breaking)

Co-authored-by: Cursor <cursoragent@cursor.com>
@eschultink
eschultink merged commit ff63cac into main Aug 17, 2026
24 of 26 checks passed
@eschultink
eschultink deleted the s231-qual-issues branch August 17, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants