S233 salesforce header passthrough - #1422
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrow, consistent with the existing rules schema (allowedRequestHeaders), and the changelog entry clearly captures the user-visible behavior change.
Pull request overview
This PR updates the prebuilt Salesforce sanitization rules to allow passthrough of two Salesforce control headers so callers can tune/inspect query behavior (notably batchSize via Sforce-Query-Options) instead of having those headers dropped by the proxy.
Changes:
- Add
allowedRequestHeadersto the relevant Salesforce endpoints soSforce-Limit-InfoandSforce-Query-Optionsare forwarded when present. - Document the behavioral change in
CHANGELOG.mdunder a new “Unreleased” section.
File summaries
| File | Description |
|---|---|
| docs/sources/salesforce/salesforce.yaml | Allows forwarding Sforce-Limit-Info and Sforce-Query-Options on composite/query/task/event-related endpoints. |
| CHANGELOG.md | Notes the new header-forwarding behavior and its operational motivation (mitigating timeouts via smaller batch sizes). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eschultink
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salesforce rules update after https://github.com/Worklytics/evalengin/pull/9053. Just adding support for headers.
Fixes
Features
Update psoxy rules
Logistics
Change implications
CHANGELOG.mdanything that will show up interraform plan/applythat isn'tobviously a no-op?
alpha, requires major versionchange