Skip to content

Comments

save old strings as old and not as current#553

Open
timse201 wants to merge 1 commit intoWordPress:trunkfrom
timse201:patch-2
Open

save old strings as old and not as current#553
timse201 wants to merge 1 commit intoWordPress:trunkfrom
timse201:patch-2

Conversation

@timse201
Copy link

trac ticket: 6320

If we sync strings from dev to stable, the overwritten string in stable will fire gp_translation_prepare_for_save again (if I'm right). Because there is no check for old strings, it will become current again, which leads to 2 new current strings in stable.
This PR adds a check for status old.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props timse201.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant