wp_theme_has_theme_json: add public method to know whether the theme supports theme.json - #3556
Closed
oandregal wants to merge 15 commits into
Closed
wp_theme_has_theme_json: add public method to know whether the theme supports theme.json#3556oandregal wants to merge 15 commits into
wp_theme_has_theme_json: add public method to know whether the theme supports theme.json#3556oandregal wants to merge 15 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket https://core.trac.wordpress.org/ticket/56975
Related Gutenberg PRs:
wp_theme_has_theme_jsonas a public API to know whether a theme has atheme.jsongutenberg#45168WP_Theme_JSON_Resolver:theme_has_support()gutenberg#45380theme.jsonobject caches non persistent gutenberg#46150wp_initial_constants()are defined gutenberg#45979Lnking to Gutenberg's 6.2 backport tracking ticket.
What
Adds a new public method
wp_theme_has_theme_jsonthat checks whether a theme has atheme.jsonfile.Why
Part of WordPress/gutenberg#45171
This offers consumers a public API so they don't have to rely on private code. Additionally, it uses the object cache under the
theme_jsongroup to maintain this data, consolidating with the changes done for settings (core PR) and settings (core PR soon, see Gutenberg PR instead).How
Creates the new public method, substitutes usage, and deprecates the old one.
Test