Skip to content

Administration: Guard network admin bootstrap on single sites - #12933

Draft
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-38076-network-admin-guard
Draft

Administration: Guard network admin bootstrap on single sites#12933
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-38076-network-admin-guard

Conversation

@ArkaPrabhaChowdhury

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury commented Aug 7, 2026

Copy link
Copy Markdown

Summary

  • Load WordPress before the network administration bootstrap.
  • Reject network-admin requests on single-site installs before plugin-page dispatch.
  • Add regression coverage for the single-site bootstrap path.

Why

wp-admin/network/admin.php previously loaded wp-admin/admin.php before checking is_multisite(). That allowed plugin-generated network admin pages to be dispatched on single-site installations before the request was rejected.

Trac ticket: https://core.trac.wordpress.org/ticket/38076
Matching contribution issue: https://github.com/rtCamp/wp-contributions/issues/3744

Testing

  • php -l src/wp-admin/network/admin.php
  • php -l tests/phpunit/tests/admin/wpNetworkAdmin.php
  • php vendor/bin/phpcbf --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.php
  • php vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.php
  • PHPUnit is blocked locally because the test database is unavailable.

@ArkaPrabhaChowdhury

Copy link
Copy Markdown
Author

Matching contribution issue: https://github.com/rtCamp/wp-contributions/issues/3744

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant