Auto approve self pings follow up - #12928
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
jeremyfelt
left a comment
There was a problem hiding this comment.
I'm also curious whether url_to_postid() is good enough or if some additional checks could help. And whether there's a better spot for the filter in general. I'll have a better opinion to share tomorrow :)
| * @param string $url The URL the pingback was sent from. | ||
| */ | ||
| return (bool) apply_filters( 'auto_approve_pingback', $approve_pingback, $source_id, $url ); | ||
| return (bool) apply_filters( 'wp_auto_approve_pingback', $approve_pingback, $source_id, $url ); |
There was a problem hiding this comment.
What about something more generic like wp_auto_approve_self_ping? (Or mention or comment or...)
I feel like we aren't far away from registered custom comment types and it would be nice if those (e.g. webmention) could also easily opt in to something like this.
There was a problem hiding this comment.
This filter right now allows filtering the condition for any ringback and not just self pingback, the default value is different between pingbacks though. So I think the current name is better personally.
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for the quick follow-up. This is looking good to me.
Makes a few updates:
wp_.Trac ticket: https://core.trac.wordpress.org/ticket/65016
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.