Skip to content

Auto approve self pings follow up - #12928

Open
peterwilsoncc wants to merge 6 commits into
WordPress:trunkfrom
peterwilsoncc:follow/65016-auto-approve-self-pings
Open

Auto approve self pings follow up#12928
peterwilsoncc wants to merge 6 commits into
WordPress:trunkfrom
peterwilsoncc:follow/65016-auto-approve-self-pings

Conversation

@peterwilsoncc

Copy link
Copy Markdown
Contributor

Makes a few updates:

  • Version annotations to 7.1.0
  • Clarifies "this site" means "the same site" in various docs.
  • Prefixes the new filter with wp_.
  • Extends the tests:
    • adds test to ensure MS sub-site posts are not auto approved
    • adds test to ensure that post ID sent to filter is zero for external sites.
    • adds docs for each test

Trac ticket: https://core.trac.wordpress.org/ticket/65016

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@jeremyfelt jeremyfelt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also curious whether url_to_postid() is good enough or if some additional checks could help. And whether there's a better spot for the filter in general. I'll have a better opinion to share tomorrow :)

* @param string $url The URL the pingback was sent from.
*/
return (bool) apply_filters( 'auto_approve_pingback', $approve_pingback, $source_id, $url );
return (bool) apply_filters( 'wp_auto_approve_pingback', $approve_pingback, $source_id, $url );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something more generic like wp_auto_approve_self_ping? (Or mention or comment or...)

I feel like we aren't far away from registered custom comment types and it would be nice if those (e.g. webmention) could also easily opt in to something like this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter right now allows filtering the condition for any ringback and not just self pingback, the default value is different between pingbacks though. So I think the current name is better personally.

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up. This is looking good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants