Build/Test Tools: Add unit test for send_frame_options_header() - #12922
Open
irozum wants to merge 1 commit into
Open
Build/Test Tools: Add unit test for send_frame_options_header()#12922irozum wants to merge 1 commit into
irozum wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PHPUnit coverage for
send_frame_options_header()inwp-includes/functions.php, which currently has no test coverage. This change is test-only and adds no production behaviour — it does not touch any file undersrc/. The new test calls the function directly and asserts, viaxdebug_get_headers(), that both theX-Frame-Options: SAMEORIGINandContent-Security-Policy: frame-ancestors 'self';headers are sent — the function's entire observable behaviour, since it takes no parameters and returns nothing. The test is marked@requires function xdebug_get_headersand runs in a separate process (@runTestsInSeparateProcesses), following the existing precedent for header assertions intests/phpunit/tests/oembed/headers.php, so it is skipped rather than failing on environments without the Xdebug extension loaded. I verified the test is meaningful by temporarily changing theX-Frame-Optionsvalue sent insend_frame_options_header()and confirming the test failed, then reverted the change and confirmed it passes again. I did not add a test for theheaders_sent()guard clause (the early return when headers were already sent) — PHPUnit'sbeStrictAboutOutputDuringTestsbuffers test output internally, so producing real output from within a test does not actually flipheaders_sent()to true in this harness, and I did not want to force a fragile workaround for that branch.Trac ticket: https://core.trac.wordpress.org/ticket/59851
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Ticket triage/selection, reading the existing implementation and test conventions, writing the test file, and running the verification loop (green/red/green). All output was reviewed by me before committing.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.