fix: bound Playwright browser install with a timeout and retry - #34
Merged
Conversation
A hung archive.ubuntu.com mirror let `playwright install --with-deps` sit silently for 27+ minutes, burning the job's full 30-minute timeout-minutes budget on a single stalled apt-get fetch instead of failing fast. Wrap each install attempt in `timeout 5m` and retry once, so a stalled mirror fails or recovers within ~10 minutes instead of consuming the whole job. Also restores the Playwright browser cache key fix (key on the resolved Playwright version, not the full lockfile hash) that was written but never actually merged to main -- it only existed on the stale fix/revert-hanging-globalsetup-warmup branch, which got squash-merged before that particular commit was cherry-picked over.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 63.90% 63.90%
Complexity 35 35
=========================================
Files 7 7
Lines 266 266
=========================================
Hits 170 170
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhung for the full 30-minutetimeout-minutesbudget and got cancelled — a stalledarchive.ubuntu.commirror letplaywright install --with-depssit silently with no timeout of its own.timeout 5mwith one retry, so a stalled mirror fails or recovers within ~10 minutes instead of eating the whole job.main.Test plan
playwright / Playwright Testsjob completing well under 30 minutesCache Playwright browserslooks correct in the job logs