fix: make playwright.yml workflow_call-only like its CI siblings - #32
Merged
Conversation
playwright.yml had its own pull_request/push triggers and concurrency
block on top of being called as a job from ci.yml. Concurrency
expressions in a called reusable workflow resolve in the caller's
context, so its group collapsed to the exact same group as ci.yml's
own top-level concurrency ("CI-refs/heads/main"), and GitHub cancelled
the nested playwright job before it could run -- flipping ci.yml's
conclusion to failure on nearly every push even though every visible
job passed. Dropping the standalone triggers/concurrency, to match
phpcs.yml/phpstan.yml/phpunit.yml/plugin-check.yml/typos.yml, removes
the collision and stops Playwright from running twice per push.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 63.90% 63.90%
Complexity 35 35
=========================================
Files 7 7
Lines 266 266
=========================================
Hits 170 170
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright.ymlhad its ownpull_request/pushtriggers and aconcurrencyblock on top of being called as a job fromci.yml.${{ github.workflow }}resolved to"CI"— the same value asci.yml's own top-level concurrency group (CI-refs/heads/main). The nestedplaywrightjob collided with the group its own parent run already occupied, so GitHub cancelled it before it could run, which flipped the wholeCIrun to failure on nearly every push tomaineven though every visible job (phpcs, phpstan, phpunit, plugin-check, typos) passed. That's what was keeping the CI badge red.ci.yml'suses:call, once via its own standalone trigger.workflow_call-only, matchingphpcs.yml/phpstan.yml/phpunit.yml/plugin-check.yml/typos.yml, all of which are call-only with no concurrency block of their own.gh api .../branches/main/protection/required_status_checksthat "Playwright"/"Playwright Tests" is not a required status check, so this doesn't affect branch protection.Side effect: Playwright will now run on every PR into
mainvia theci.ymlumbrella rather than only when**.php/**.ts/tests/e2e/**/etc. change, since per-job path filtering isn't supported inside a reusable-workflow call.Test plan
actionlint .github/workflows/playwright.ymlpassesCIcompleting successfully (single Playwright execution, no spurious failure)