Skip to content

[PHP] Keep apply-runtime paths rooted while joining local paths - #509

Open
adamziel wants to merge 1 commit into
adamziel/join-wpcloud-document-root-pathsfrom
adamziel/join-apply-runtime-local-paths
Open

[PHP] Keep apply-runtime paths rooted while joining local paths#509
adamziel wants to merge 1 commit into
adamziel/join-wpcloud-document-root-pathsfrom
adamziel/join-apply-runtime-local-paths

Conversation

@adamziel

@adamziel adamziel commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

apply-runtime now joins its local document-root, WordPress-index, manifest-removal, and runtime-output paths through wp_join_unix_paths(). A flat document root of / remains / instead of becoming the process working directory after trailing-slash cleanup.

Tests: cd tests && ../vendor/bin/phpunit Import/ProductionDropInRemovalTest.php Import/RemoteUploadProxyRuntimeTest.php; vendor/bin/phpstan analyze --memory-limit=1G packages/reprint-client/src/import.php.

@adamziel
adamziel force-pushed the adamziel/join-wpcloud-document-root-paths branch from 2fbc8d5 to f662860 Compare August 7, 2026 00:55
@adamziel
adamziel force-pushed the adamziel/join-apply-runtime-local-paths branch from 650dbc0 to 504ed36 Compare August 7, 2026 00:55
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 9.84 s 9.35 s ⚪ +487 ms (+5.2%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.60 s 3.53 s ⚪ +71 ms (+2.0%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 13.44 s 12.88 s ⚪ +558 ms (+4.3%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant