Skip to content

[Push] Select files-push progress output - #500

Open
adamziel wants to merge 1 commit into
adamziel/files-push-stage-progressfrom
adamziel/select-files-push-progress-output
Open

[Push] Select files-push progress output#500
adamziel wants to merge 1 commit into
adamziel/files-push-stage-progressfrom
adamziel/select-files-push-progress-output

Conversation

@adamziel

@adamziel adamziel commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

files-push can now select terminal or JSONL progress explicitly while keeping TTY detection as the default.

This is stacked on #484 and extends the --progress=auto|tty|jsonl selector from #492 to files-push.

# Keep the single progress bar when stdout is captured.
reprint files-push "$URL" --state-dir="$STATE_DIR" --fs-root="$FS_ROOT" \
  --secret="$SECRET" --progress=tty

# Keep the existing JSONL stream when running in a terminal.
reprint files-push "$URL" --state-dir="$STATE_DIR" --fs-root="$FS_ROOT" \
  --secret="$SECRET" --progress=jsonl

--progress=auto preserves the current behavior: terminal output on a TTY and JSONL otherwise. tty forces the bar from #484; jsonl forces the existing push_progress records and final result. Both presentations consume the same sender progress snapshot. The selection belongs to one invocation and is not written to sender state.

This uses a progress selector instead of a general --format option because it changes only the live progress presentation, not Reprint's result schema. The shape follows BuildKit's --progress=auto|tty|rawjson selector, while jsonl names the line-delimited format Reprint already emits.

Explicit tty and jsonl modes reject --verbose, so detailed log lines cannot corrupt the selected presentation.

Testing

Run files-push --progress=tty with stdout captured and check that one bar redraws through Indexing, Pushing, and Committing. Run --progress=jsonl directly in a terminal and check that each output line is a JSON record. Try either explicit mode with --verbose and check that the command rejects the combination before starting a sender.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 8.91 s 8.84 s ⚪ +73 ms (+0.8%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.40 s 3.38 s ⚪ +18 ms (+0.5%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 12.31 s 12.22 s ⚪ +91 ms (+0.7%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

@adamziel
adamziel force-pushed the adamziel/files-push-stage-progress branch from a2c0f81 to d6ca26f Compare August 7, 2026 00:17
@adamziel
adamziel force-pushed the adamziel/select-files-push-progress-output branch from d790d26 to 2df8dd0 Compare August 7, 2026 00:17
@adamziel
adamziel force-pushed the adamziel/files-push-stage-progress branch from d6ca26f to d31b1a4 Compare August 7, 2026 00:42
@adamziel
adamziel force-pushed the adamziel/select-files-push-progress-output branch 2 times, most recently from 91aff4b to ec9bfd2 Compare August 7, 2026 00:57
@adamziel
adamziel force-pushed the adamziel/files-push-stage-progress branch from d31b1a4 to ee3ed24 Compare August 7, 2026 00:57
@adamziel
adamziel force-pushed the adamziel/files-push-stage-progress branch from ee3ed24 to ec8fe82 Compare August 7, 2026 09:32
@adamziel
adamziel force-pushed the adamziel/select-files-push-progress-output branch from ec9bfd2 to cb64787 Compare August 7, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant