[Push] Select files-push progress output - #500
Open
adamziel wants to merge 1 commit into
Open
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
8.91 s | 8.84 s | ⚪ +73 ms (+0.8%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.40 s | 3.38 s | ⚪ +18 ms (+0.5%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 12.31 s | 12.22 s | ⚪ +91 ms (+0.7%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
adamziel/files-push-stage-progress
branch
from
August 7, 2026 00:17
a2c0f81 to
d6ca26f
Compare
adamziel
force-pushed
the
adamziel/select-files-push-progress-output
branch
from
August 7, 2026 00:17
d790d26 to
2df8dd0
Compare
adamziel
force-pushed
the
adamziel/files-push-stage-progress
branch
from
August 7, 2026 00:42
d6ca26f to
d31b1a4
Compare
adamziel
force-pushed
the
adamziel/select-files-push-progress-output
branch
2 times, most recently
from
August 7, 2026 00:57
91aff4b to
ec9bfd2
Compare
adamziel
force-pushed
the
adamziel/files-push-stage-progress
branch
from
August 7, 2026 00:57
d31b1a4 to
ee3ed24
Compare
adamziel
force-pushed
the
adamziel/files-push-stage-progress
branch
from
August 7, 2026 09:32
ee3ed24 to
ec8fe82
Compare
adamziel
force-pushed
the
adamziel/select-files-push-progress-output
branch
from
August 7, 2026 09:32
ec9bfd2 to
cb64787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
files-pushcan now select terminal or JSONL progress explicitly while keeping TTY detection as the default.This is stacked on #484 and extends the
--progress=auto|tty|jsonlselector from #492 tofiles-push.--progress=autopreserves the current behavior: terminal output on a TTY and JSONL otherwise.ttyforces the bar from #484;jsonlforces the existingpush_progressrecords and final result. Both presentations consume the same sender progress snapshot. The selection belongs to one invocation and is not written to sender state.This uses a progress selector instead of a general
--formatoption because it changes only the live progress presentation, not Reprint's result schema. The shape follows BuildKit's--progress=auto|tty|rawjsonselector, whilejsonlnames the line-delimited format Reprint already emits.Explicit
ttyandjsonlmodes reject--verbose, so detailed log lines cannot corrupt the selected presentation.Testing
Run
files-push --progress=ttywith stdout captured and check that one bar redraws throughIndexing,Pushing, andCommitting. Run--progress=jsonldirectly in a terminal and check that each output line is a JSON record. Try either explicit mode with--verboseand check that the command rejects the combination before starting a sender.