Move processor implementations to their public paths - #303
Merged
Conversation
adamziel
force-pushed
the
adamziel/restore-public-processor-implementations
branch
2 times, most recently
from
August 7, 2026 15:23
140e205 to
43f22b5
Compare
adamziel
force-pushed
the
adamziel/restore-public-processor-class-names
branch
from
August 7, 2026 15:23
6f2ef88 to
de42d76
Compare
adamziel
force-pushed
the
adamziel/restore-public-processor-class-names
branch
from
August 7, 2026 15:56
de42d76 to
43f22b5
Compare
adamziel
changed the title
adamziel
changed the base branch from
adamziel/restore-public-processor-implementations
to
adamziel/prepare-processor-file-moves
August 7, 2026 15:56
adamziel
added a commit
that referenced
this pull request
Aug 7, 2026
Moves the four public alias loaders into temporary `loaders/` directories so #303 can present the implementation relocations as exact Git renames. The temporary loaders accept either adjacent stack state: the implementations under `PHP/` in this PR, or the public paths after #303. The implementation files receive only a PHPCS directive that moves with their unchanged bytes. #305 removes the loaders and directives while restoring the public class declarations. ## Stack 1. #304 — vacate the destination paths 2. #303 — move four byte-identical implementation files 3. #305 — restore the public class declarations and remove temporary loaders After each base PR merges, retarget the next PR to `trunk`. ## Testing The Data Liberation, XML, and Markdown suites pass. PHPCS, syntax checks, direct-loader checks, and root-autoload checks pass.
adamziel
force-pushed
the
adamziel/restore-public-processor-class-names
branch
from
August 7, 2026 16:03
43f22b5 to
95a86a9
Compare
adamziel
added a commit
that referenced
this pull request
Aug 7, 2026
Renames the four relocated `PHP*` implementation classes to their public names and removes the temporary loaders introduced by #304. With #303 merged, Files changed contains only the class declaration cleanup and temporary-loader removal. The resulting tree contains neither the retired `PHP*` class names nor the `PHP/` and `loaders/` directories. ## Stack 1. #304 — vacate the destination paths 2. #303 — move four byte-identical implementation files 3. #305 — restore the public class declarations and remove temporary loaders ## Testing The Data Liberation, XML, and Markdown suites pass. PHPCS and syntax checks pass. A root-autoload check confirms the public classes load, the retired `PHP*` classes do not, and `WP_HTML_Processor` remains a `WP_HTML_Tag_Processor` subclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the retained URL-in-text, HTML, and XML implementation files out of the
PHP/sidecar directories and into their public processor paths.Files changed contains exactly four 100% renames with zero additions and zero deletions. No implementation byte changes in this PR.
Stack
Testing
The Data Liberation, XML, and Markdown suites pass. PHPCS, syntax checks, direct-loader checks, and root-autoload checks pass.