Editor: Remove sidebar tabs focus sync effect - #81020
Conversation
Mamaduka
added
[Type] Code Quality
|
Size Change: -143 B (0%) Total Size: 7.76 MB 📦 View Changed
|
| const { Tabs } = unlock( componentsPrivateApis ); | ||
|
|
||
| const SidebarHeader = ( _, ref ) => { | ||
| export default function SidebarHeader() { |
There was a problem hiding this comment.
I think we'll need to add a CHANGELOG entry since we're technically changing the API here.
There was a problem hiding this comment.
It's a local component and isn't used anywhere else.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you for cleaning this up, I missed it in my original Ariakit update PR 🙏 |
3 participants
What?
Extracted from #81006.
PR removes the focus-sync effect that kept the focused and selected tabs together, along with the data-tab-id attributes and the ref plumbing that existed only to serve them.
Why?
The focus-sync effect was added in #58041 to fix a race when tabbing off the last block: focus moved to the active Block tab, then
interfaceStorenoticed focus had left the blocks and switched selection to Post, leaving one tab focused and the other selected. That race is no longer reachable. The post title and blocks are a single contenteditable writing flow, so there are no per-block tab stops to leave, and Tab exits straight to the sidebar. The navigation it depended on was removed in #65204, which also deleted the guard test #58041 had updated.Testing Instructions
Testing Instructions for Keyboard
Same.
Use of AI Tools
Assisted by Claude.