Boot: Merge root theme providers - #79679
Closed
ciampo wants to merge 2 commits into
Closed
Conversation
|
Size Change: -20 B (0%) Total Size: 7.61 MB 📦 View Changed
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What?
Follow up to #78587.
Tries merging the two adjacent boot root
ThemeProviderinstances so the root provider and.boot-layoutuse the same admin theme color context.Why?
The overscroll fix in #78587 needs a body background token that resolves in the same theme context as
.boot-layout. Using one root provider should make the document-level tokens forwarded byisRootmatch the boot layout tokens, instead of requiring a separate foreground-token workaround in the generated wp-admin template.How?
ThemeProviderthat only overrodebackgroundto#f8f8f8.--wpds-color-background-surface-neutral-weak, matching.boot-layout.Testing Instructions
freshandlightadmin color schemes.ThemeProviderwarning appears in the console.Testing Instructions for Keyboard
No keyboard interaction changes are expected. Use keyboard navigation through the boot page and confirm focus order is unchanged.
Screenshots or screencast
Not included. This is an experiment to validate the provider structure discussed in #78587.
Use of AI Tools
This PR was drafted with help from OpenAI Codex. I reviewed the generated changes and ran the checks listed below.
Checks
npm run lint:js -- packages/boot/src/components/root/index.tsx packages/boot/src/components/root/single-page.tsxgit diff --checknpx tsgo --build packages/boot/tsconfig.jsoncurrently fails before these changes on missing generatedworker-codemodules inpackages/vipsandpackages/video-conversion.