Change Accordion block toolbar label to spell “Add Accordion Item”

[sunyatasattva]

What?

The block toolbar button to add new Accordion Items within an Accordion block, only spells “Add”, which is highly ambiguous. This PR merely changes the label to spell out “Add Accordion Item” instead, which is in line with the label appearing in the inserter and similar behavior in the Tabs block.

Testing Instructions

1. Add an Accordion block.
2. Select it and verify that the toolbar button spells “Add Accordion Item”.

Screenshots or screencast

Before	After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sunyatasattva <sunyatasattva@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

Thanks for the PR!

I believe the current terminology was a deliberate decision. See: #71388

Adds an "Add" button to the Accordion block toolbar:

This implementation is based on the "Add" button in the Gallery block:

The toolbar may have various buttons added by the developer. Furthermore, the text Add Accordion Item seems too long. In addition, it might be even longer depending on the locale.

Personally, I prefer to keep it as Add. Or, it might be possible to make it slightly shorter, like Add item

cc @mikachan @WordPress/gutenberg-design

[sunyatasattva]

I agree that “Add Accordion Item” might feel too long, but “Add” is way too short and ambiguous. On the extreme case, imagine being on a screen reader: “Add” is completely confusing.

The new Tabs block uses “Add tab”, and I think that should be the direction. I didn't know about the gallery, and I was just about to go test it to see what it does, when it literally dawned to me: even in this conversation, as I haven't used the Gallery block too much, I have no clue what “Add” might do. Does it add an image to the gallery, or a gallery, or a section?

Especially because, as you mention, the toolbar can be extended, “Add” is even more pernicious: any developer could insert an “Add” button, so you wouldn't really know what it does and if that's specific to the current Accordion block, or is something that gets inserted in all toolbars.

“Add tab” has the luck of being short in the English language. But “Add Accordion Item” in Chinese would be 新增折叠项 (“Add tab” would be 新增标签页, same length). So, while I symphatize with it, I feel that using the length argument is also needlessly anglo-centric: in any label in our UI, we can never predict how long it would be in all languages.

With that said, I would say that at the very least we should go for “Add item”, or “Add section”.

[jasmussen]

Thanks for the ping. I agree with both of you, but we have to choose between tradeoffs:

• Do we remain consistent with other nesting containers and their "Add" actions, and account for mobile?
• Do we break consistency for clarity and risk the toolbar getting cropped on mobile?

I want to not have strong opinions on which of the above two we choose, but possibly a middleground would be "Add item" or "Add section" as noted (note, sentence case).

And thank you for contributing!

[t-hamano]

Thank you for the feedback! Let's change it to Add item. Following this, we should probably also change Add image in the Gallery block's toolbar.

If possible, let's merge and backport this PR before RC1, when string freezing will start.

[mikachan]

Let's change it to Add item. Following this, we should probably also change Add image in the Gallery block's toolbar.

+1 to this! Thanks all 🙇

[t-hamano]

@sunyatasattva, Based on the discussion, I have changed the text to Add item. Thanks for your contribution!

[github-actions]

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 640fcf4